-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor dependency formatting glitch #4116
Comments
This is probably the result of changes in #3657. What do you think the correct output should be? |
For simplicity, I would keep the formatting the old way, if only to remove the context-sensitive nature of the comma. I would suggest
and
as all log components are space-separated and don't require extra context-aware information for handling the comma. Alternatively
which only requires appending the comma to the version string, if present. I don't have any hard opinions on this, even keeping it how it is modulo the trailing comma after the Your ideas? |
I was just trying to keep things the same, unfortunately the logging wasn't consistent. after this PR, I get
and
|
On Meson 0.47.2 I get
On HEAD Meson I get
due to the system GMock missing a version specifier.
The text was updated successfully, but these errors were encountered: