Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor dependency formatting glitch #4116

Closed
SoapGentoo opened this issue Sep 2, 2018 · 3 comments
Closed

Minor dependency formatting glitch #4116

SoapGentoo opened this issue Sep 2, 2018 · 3 comments

Comments

@SoapGentoo
Copy link
Member

On Meson 0.47.2 I get

Dependency GMock found: YES (prebuilt)

On HEAD Meson I get

Dependency GMock found: YES , prebuilt

due to the system GMock missing a version specifier.

@jon-turney
Copy link
Member

This is probably the result of changes in #3657.

What do you think the correct output should be?

@SoapGentoo
Copy link
Member Author

SoapGentoo commented Sep 4, 2018

For simplicity, I would keep the formatting the old way, if only to remove the context-sensitive nature of the comma. I would suggest

Dependency GMock found: YES (prebuilt)

and

Dependency GMock found: YES 1.9.0 (pkgconfig)

as all log components are space-separated and don't require extra context-aware information for handling the comma. Alternatively

Dependency GMock found: YES (1.9.0, pkgconfig)

which only requires appending the comma to the version string, if present. I don't have any hard opinions on this, even keeping it how it is modulo the trailing comma after the YES is just as fine, just from a programmatic point-of-view this last option is the hardest to implement.

Your ideas?

@jon-turney
Copy link
Member

Your ideas?

I was just trying to keep things the same, unfortunately the logging wasn't consistent.

after this PR, I get

Dependency GTest found: NO (tried pkgconfig and system)

and

Dependency GTest found: YES (building self)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants