-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating a job from scheduled to dependent leaves the job continuing to fire on original schedule #627
Comments
Looking at the code in DependentJobResource.scala `val parents = jobGraph.parentJobs(newJob)
It seems the jobScheduler.removeSchedule(j) should be on the case j where the old job was a ScheduleBasedJob not when it was a dependent based job. |
I fixed this in the following PR: |
One step ahead! Thanks Califax! |
Should be marked as closed now. |
Hi Guys,
I'm seeing some behaviour which I don't think is intended/appropriate, I thought I'd raise a issue here to see if it merits further investigation (or if I've got the wrong end of the stick).
It appears that updating a job from scheduled to dependent causes the original schedule to remain intact, resulting in the job firing twice: triggered once by the schedule, and once by the parent job completing successfully.
Scenario
I add the following 2 scheduled jobs:
I then update test_B to be a dependent job of test_A:
testdependentB.json
Result
The test_A job executes at the correct time, and kicks off test_B after it succeeds. But test_B then executes exactly 1 minute after test_A, which matches the original schedule set.
As soon as I update test_B to be dependent, I can no longer see any mention of the schedule being held in the job state either through the chronos REST api or by manually inspecting the state of the attached zookeeper; so, from my point of view, this isn't the expected behaviour.
I've had a look at the api resources in the code base (specifically the DependentJobResource & JobScheduler) but can't see anything obvious, could someone shed some light on what's going on here?
Setup
I'm using chronos-2.4.0 & mesos-0.24.1 installed via-yum, & running chronos with the following command:
The output of
java -version
is:Thanks for your time and the awesome tool, chronos rocks,
Ioan
The text was updated successfully, but these errors were encountered: