Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver graceful shutdown option #273

Open
janisz opened this issue Feb 2, 2017 · 1 comment
Open

Add driver graceful shutdown option #273

janisz opened this issue Feb 2, 2017 · 1 comment

Comments

@janisz
Copy link

janisz commented Feb 2, 2017

There is no way to stop the driver after all messages are sent to Mesos. Add GracefulStop function to driver that will wait for all message to be delivered and then stop the driver. GracefulStop should be blocking.

@medzin
Copy link

medzin commented Feb 3, 2017

This part looks like unfinished, internally MesosExecutorDriver uses TODO context:
https://github.com/mesos/mesos-go/blob/master/executor/executor.go#L128

There should be a way to pass own Context (for example context.WithDeadline()) to Messenger interface used by driver to communicate with Mesos. It will allow to wait for the messages to be delivered or fail after defined time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants