Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: is it possible to start making github releases?🤔 #26

Closed
kloczek opened this issue Sep 8, 2023 · 3 comments
Closed

RFE: is it possible to start making github releases?🤔 #26

kloczek opened this issue Sep 8, 2023 · 3 comments

Comments

@kloczek
Copy link

kloczek commented Sep 8, 2023

Is it possible next time on release new version make the github release to have entry on https://github.com/messense/nh3/releases? 🤔
On create github release entry is created email notification to those whom have set in your repo the web UI Watch->Releases.
gh release can contain additional comments (li changelog) or additional assets like release tar balls (by default it contains only assets from git tag) however all those part are not obligatory.
In simplest variant gh release can be empty because subiekt of the sent email contains git tag name.

I'm asking because my automation process uses those email notifications by trying to make preliminary automated upgrades of building packages, which allows saving some time on maintaining packaging procedures.
Probably other people may be interested to be instantly informed about release new version as well.

Description:
https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository
https://github.com/marketplace/actions/github-release
https://pgjones.dev/blog/trusted-plublishing-2023/
jbms/sphinx-immaterial#281 (comment)

@adamchainz
Copy link
Contributor

@messense This user spammed hundreds of repositories with identical issues. I closed them on my projects, citing that I don’t want to change my process and promise to commit to making releases going forward. Up to you of course.

@messense
Copy link
Owner

messense commented Dec 7, 2023

@messense messense closed this as completed Dec 7, 2023
@kloczek
Copy link
Author

kloczek commented Dec 7, 2023

Just checked my automation and I can confirm that new version notification has been successfully processed 👍
New version builds and passes test suite correctly with one small warning

===================================================================================== warnings summary ======================================================================================
tests/test_nh3.py::test_clean_with_attribute_filter
  /usr/lib/python3.8/site-packages/_pytest/unraisableexception.py:78: PytestUnraisableExceptionWarning: Exception ignored in: ('img', 'src', 'foo')

  Traceback (most recent call last):
    File "/home/builder/rpmbuild/BUILD/nh3-0.2.15/tests/test_nh3.py", line 71, in test_clean_with_attribute_filter
      nh3.clean(html, attribute_filter=lambda _element, _attribute, _value: True)
  TypeError: expected attribute_filter to return str or None

    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=============================================================================== 4 passed, 1 warning in 0.07s ================================================================================

Nevertheless tank you very much 👍
I really appreciated for what you've done😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants