Skip to content

Commit 3f9a7f5

Browse files
aobo-yfacebook-github-bot
authored andcommitted
check ufmt before flake8 in ci (#1089)
Summary: `ufmt` (`black + usort`) overlaps with many rules of `flake8`. `ufmt` can automatically fix many violations given by `flake8`. So we should screen if any errors can be auto fixed by `ufmt` at first to avoid wasting people's time. And only show the rest `flake8` errors that require manual fixes. Pull Request resolved: #1089 Reviewed By: cyrjano Differential Revision: D42006058 Pulled By: aobo-y fbshipit-source-id: 711065a35da4816c7fd30068b1c5734de961caa1
1 parent 8bc12c8 commit 3f9a7f5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ jobs:
141141
steps:
142142
- checkout
143143
- pip_install
144-
- lint_flake8
145144
- ufmt_check
145+
- lint_flake8
146146
- sphinx
147147

148148
test_py36_pip:

0 commit comments

Comments
 (0)