Metric Logging updates 6/N - Enable SFT metrics / delete old file #396
+986
−1,592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
October 8, 2025 08:38
…estamp_logging_diff2
…estamp_logging_diff3
…estamp_logging_diff3
…estamp_logging_diff3
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Do not review]
Branch of #363. We should merge it first.
SFT_v2 uses Forge actors. This makes natural to integrate the metric logging system developed for GRPO. This PR enables logging in SFT and used Datasets. It also deleted the older version of metric logging that is no longer needed.