Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXME for license file checksum is present even if all license checksums are resolved #18

Open
pbrkr opened this issue Sep 19, 2020 · 0 comments

Comments

@pbrkr
Copy link
Contributor

pbrkr commented Sep 19, 2020

Looking at the same output as #17, the FIXME message for incomplete license file checksums is present in the recipe even if all checksums have been successfully resolved:

# FIXME: update generateme with the real MD5 of the license file
LIC_FILES_CHKSUM = " \
    file://hello/LICENSE;md5=86d3f3a95c324c9479bd8986968f4327 \
"

This is liable to confuse anyone searching for FIXME tags in a repository.

I see that this line is present in the template text. Perhaps instead there should be a placeholder like {lic_files_fixme} which can be set to an empty string if all checksums are resolved, or to the fixme warning if some checksums were not resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant