Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] remove unnecessary mc system libraries #66

Open
kaihiroi opened this issue Nov 5, 2024 · 1 comment
Open

[feature] remove unnecessary mc system libraries #66

kaihiroi opened this issue Nov 5, 2024 · 1 comment
Labels
priority: low Issues or pull requests with low priority that can be addressed after other tasks type: feature Issues or pull requests related to new feature proposals or enhancements

Comments

@kaihiroi
Copy link
Contributor

kaihiroi commented Nov 5, 2024

Problem

The new --decode-internal option in forge makes existing tracer and logger features redundant, increasing maintenance and performance overhead.

Solution

Remove tracer and logger features and utilize the --decode-internal option in forge to simplify the codebase and reduce maintenance.

Alternatives

Keep tracer and logger while using the --decode-internal option together.
Enhance tracer and logger to match the functionality of --decode-internal.

Additional context

The --decode-internal option in forge automates internal function calling decoding, streamlining debugging processes and rendering tracer and logger redundant.

@kaihiroi kaihiroi added the type: feature Issues or pull requests related to new feature proposals or enhancements label Nov 5, 2024
@kaihiroi kaihiroi added this to the Version 0.2.0 Release milestone Nov 5, 2024
@kaihiroi
Copy link
Contributor Author

kaihiroi commented Nov 5, 2024

After investigating the --decode-internal option, applying it to the standard mc deployment process results in the forge test command being killed, likely due to resource consumption issues (e.g., [1] 98864 killed forge test --mc DAOBehaviorTest --decode-internal -vvvvv).
Therefore, we have decided to continue enabling the current mc debugger until Foundry supports more detailed decode options or the mc architecture is optimized for proper display.

@kaihiroi kaihiroi removed this from the Version 0.2.0 Release milestone Nov 5, 2024
@kaihiroi kaihiroi added the priority: low Issues or pull requests with low priority that can be addressed after other tasks label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Issues or pull requests with low priority that can be addressed after other tasks type: feature Issues or pull requests related to new feature proposals or enhancements
Projects
None yet
Development

No branches or pull requests

1 participant