removed content_cb: not really used, no point in having lazy content

Author: mickeyn

lib/MetaCPAN/Document/File.pm

@@ -614,40 +614,17 @@ These attributes are not stored.
 =head2 content
 
 A scalar reference to the content of the file.
-Built by calling L</content_cb>.
 
 =cut
 
 has content => (
     is       => 'ro',
     isa      => ScalarRef,
     lazy     => 1,
-    builder  => '_build_content',
+    default  => sub { \"" },
     property => 0,
 );
 
-sub _build_content {
-    my $self = shift;
-
-    # NOTE: We used to remove the __DATA__ section "for performance reasons"
-    # however removing lines from the content will throw off pod_lines.
-    return $self->content_cb->();
-}
-
-=head2 content_cb
-
-Callback that returns the content of the file as a ScalarRef.
-
-=cut
-
-has content_cb => (
-    is       => 'ro',
-    property => 0,
-    default  => sub {
-        sub { \'' }
-    },
-);
-
 =head2 local_path
 
 This attribute holds the path to the file on the local filesystem.

lib/MetaCPAN/Model/Release.pm

@@ -321,14 +321,14 @@ sub _build_files {
 
             my $file = $file_set->new_document(
                 Dlog_trace {"adding file $_"} +{
-                    author       => $self->author,
-                    binary       => -B $child,
-                    content_cb   => sub { \( scalar $child->slurp ) },
+                    author  => $self->author,
+                    binary  => -B $child,
+                    content => $child->is_dir ? \""
+                    : \( scalar $child->slurp ),
                     date         => $self->date,
                     directory    => $child->is_dir,
                     distribution => $self->distribution,
-                    indexed      => $self->metadata->should_index_file($fpath)
-                    ? 1
+                    indexed => $self->metadata->should_index_file($fpath) ? 1
                     : 0,
                     local_path   => $child,
                     maturity     => $self->maturity,

t/document/file.t

@@ -34,13 +34,11 @@ PKG
 
         # Passing in "content" will override
         # but defaulting to package statements will help avoid buggy tests.
-        content_cb => sub {
-            \(
-                join "\n",
-                ( map { sprintf $pkg_template, $_->{name} } @$mods ),
-                "\n\n=head1 NAME\n\n${name} - abstract\n\n=cut\n\n",
-            );
-        },
+        content => \(
+            join "\n",
+            ( map { sprintf $pkg_template, $_->{name} } @$mods ),
+            "\n\n=head1 NAME\n\n${name} - abstract\n\n=cut\n\n",
+        ),
 
         %args,
     );
@@ -184,9 +182,9 @@ package MOBY::Config;
 END
 
     my $file = new_file_doc(
-        path       => 't/bar/bat.t',
-        module     => { name => 'MOBY::Config' },
-        content_cb => sub { \$content }
+        path    => 't/bar/bat.t',
+        module  => { name => 'MOBY::Config' },
+        content => \$content,
     );
 
     is( $file->abstract,
@@ -229,8 +227,8 @@ just a makefile description
 
 END
     my $file = new_file_doc(
-        name       => 'Makefile.PL',
-        content_cb => sub { \$content }
+        name    => 'Makefile.PL',
+        content => \$content,
     );
 
     is( $file->indexed, 0, 'File listed under other files is not indexed' );
@@ -268,7 +266,7 @@ AS-specific methods for Number::Phone
 END
     my $file = new_file_doc(
         module => [ { name => 'Number::Phone::NANP::ASS', version => 1.1 } ],
-        content_cb => sub { \$content }
+        content => \$content,
     );
     is( $file->sloc,                                   8, '8 lines of code' );
     is( $file->slop,                                   4, '4 lines of pod' );
@@ -297,9 +295,9 @@ C<Perl6Attribute> -- An example attribute metaclass for Perl 6 style attributes
 
 END
     my $file = new_file_doc(
-        name   => 'Perl6Attribute.pod',
-        module => [ { name => 'main', version => 1.1 } ],
-        content_cb => sub { \$content }
+        name    => 'Perl6Attribute.pod',
+        module  => [ { name => 'main', version => 1.1 } ],
+        content => \$content,
     );
     is( $file->documentation, 'Perl6Attribute' );
     is( $file->abstract,
@@ -345,8 +343,8 @@ Bar
 
 END
     my $file = new_file_doc(
-        name       => 'Foo.pod',
-        content_cb => sub { \$content }
+        name    => 'Foo.pod',
+        content => \$content,
     );
     is( $file->documentation, 'Foo', 'POD in __DATA__ section' );
     is( $file->description, 'hot stuff * Foo * Bar' );
@@ -386,7 +384,7 @@ END
     foreach my $folder ( 'pod', 'lib', 'docs' ) {
         my $file = MetaCPAN::Document::File->new(
             author       => 'Foo',
-            content_cb   => sub { \$content },
+            content      => \$content,
             distribution => 'Foo',
             name         => 'Baz.pod',
             path         => $folder . '/Foo/Bar/Baz.pod',
@@ -438,8 +436,8 @@ parsed.
 END
 
     my $file = new_file_doc(
-        name       => 'Yo.pm',
-        content_cb => sub { \$content }
+        name    => 'Yo.pm',
+        content => \$content,
     );
 
     test_attributes $file,
@@ -487,8 +485,8 @@ last-word.
 END
 
     my $file = new_file_doc(
-        name       => 'Yo.pm',
-        content_cb => sub { \$content }
+        name    => 'Yo.pm',
+        content => \$content,
     );
 
     test_attributes $file, {
@@ -540,8 +538,8 @@ POD
     };
 
     my $file = new_file_doc(
-        name       => 'Yo.pm',
-        content_cb => sub { \$content }
+        name    => 'Yo.pm',
+        content => \$content,
     );
 
     test_attributes $file, {

t/release/packages.t

@@ -48,6 +48,7 @@ test_release(
                 'Packages::BOM module starts with UTF-8 BOM';
 
             my $file = $self->file_by_path($path);
+
             is ${ $file->pod },
                 q[NAME Packages::BOM - package in a file with a BOM],
                 'pod text';