Metal3 projects are Apache 2.0 licensed and accept contributions via GitHub pull requests.
- Certificate of Origin
- Finding Things That Need Help
- Versioning
- Branches
- Contributing a Patch
- Backporting a Patch
- Breaking Changes
- Release Process
By contributing to this project you agree to the Developer Certificate of Origin (DCO). This document was created by the Linux Kernel community and is a simple statement that you, as a contributor, have the legal right to make the contribution. See the DCO file for details.
Commit message should contain signed off section with full name and email. For example:
Signed-off-by: John Doe <jdoe@example.com>
When making commits, include the -s flag and Signed-off-by section
will be automatically added to your commit message. If you want GPG
signing too, add the -S flag alongside -s.
# Signing off commit
git commit -s
# Signing off commit and also additional signing with GPG
git commit -s -SIf you're new to the project and want to help, but don't know where to start, we have a semi-curated list of issues that should not need deep knowledge of the system. Have a look and see if anything sounds interesting. Alternatively, read some of the docs on other controllers and try to write your own, file and fix any/all issues that come up, including gaps in documentation!
Baremetal Operator doesn't follow release cadence and versioning of upstream Kubernetes semantic versioning. This codebase guarantees the following:
-
A (minor) release CAN include:
- Introduction of new API versions, or new Kinds.
- Compatible API changes like field additions, deprecation notices, etc.
- Breaking API changes for deprecated APIs, fields, or code.
- Features, promotion or removal of feature gates.
- And more!
-
A (patch) release SHOULD only include backwards compatible set of bugfixes.
These guarantees extend to all code exposed in our Go Module, including types from dependencies in public APIs. Types and functions not in public APIs are not considered part of the guarantee.
We generally do not accept PRs directly against release branches, while we might accept backports of fixes/changes already merged into the main branch.
We generally allow backports of the following kinds of changes to all maintained branches:
- Critical bug fixes, security issue fixes, or fixes for bugs without easy workarounds.
- Dependency bumps for CVE (usually limited to CVE resolution; backports of non-CVE related version bumps are considered exceptions to be evaluated case by case)
- Changes required to support new Kubernetes patch versions, when possible.
- Changes to use the latest Go patch version to build controller images.
- Changes to bump the Go minor version used to build controller images, if the Go minor version of a supported branch goes out of support (e.g. to pick up bug and CVE fixes). This has no impact on users importing Baremetal Operator as we won't modify the version in go.mod and the version in the Makefile does not affect them.
- Improvements to existing docs
- Improvements to the test framework
Like any other activity in the project, backporting a fix/change is a community-driven effort and requires that someone volunteers to own the task. In most cases, the cherry-pick bot can (and should) be used to automate opening a cherry-pick PR.
We generally do not accept backports to BMO release branches that are EOL (End of life). Check the Version support guide for reference.
The main branch is where development happens. All the latest and greatest code, including breaking changes, happens on main.
The release-X.Y branches will contain stable, backwards compatible code. On every major or minor release, a new branch will be created. It is from these branches that minor and patch releases will be tagged. In some cases, it may be necessary to open PRs for bugfixes directly against stable branches, but this should generally not be the case.
Baremetal-operator maintains the most recent release/releases for all supported APIs and contract versions. Support for this section refers to CI support and the ability to backport and release patch versions; backport policy is defined above.
-
The API version is determined from the GroupVersion defined in the top-level
apis/package. -
The EOL date of each API Version is determined from the last release available once a new API version is published.
| API Version | Maintained Until |
|---|---|
| v1alpha1 | TBD (current latest) |
| v1beta1 | Upcoming (Proposal PR) |
-
For the current stable API version (v1alpha1) we support the two most recent minor releases; older minor releases are immediately unsupported when a new major/minor release is available.
-
Once we have v1beta1 API, we will determine support policies for older API versions.
-
We will maintain test coverage for all supported minor releases and for one additional release for the current stable API version in case we have to do an emergency patch release. For example, if v0.4 and v0.3 are currently supported, we will also maintain test coverage for v0.2 for one additional release cycle. When v0.5 is released, tests for v0.2 will be removed.
Note: Currently, BMO release branches are tested with CAPM3 integration/e2e tests, so dropping a test for BMO release version is dependant on CAPM3 release. As such, we might test a BMO release until we drop the test for CAPM3. Once BMO e2e tests take over, we can follow the above policy for dropping tests.
| Minor Release | API Version | Maintained Until |
|---|---|---|
| v0.4.x | v1alpha1 | when v0.6.0 will be released |
| v0.3.x | v1alpha1 | when v0.5.0 will be released |
| v0.2.x | v1alpha1 | EOL since 2023-08-30 (*) |
| v0.1.x | v1alpha1 | EOL since 2023-04-26 (*) |
(*) Previous support policy applies, older minor releases were immediately unsupported when a new major/minor release was available
- Exceptions can be filed with maintainers and taken into consideration on a case-by-case basis.
- If you haven't already done so, sign a Contributor License Agreement (see details here).
- Fork the desired repo, develop and test your code changes.
- Submit a pull request.
All code PR should be labeled with one of
⚠️ (:warning:, major or breaking changes)- ✨ (
:sparkles:, feature additions) - 🐛 (
:bug:, patch and bugfixes) - 📖 (
:book:, documentation or proposals) - 🌱 (
:seedling:, minor or other)
Individual commits should not be tagged separately, but will generally be assumed to match the PR. For instance, if you have a bugfix in with a breaking change, it's generally encouraged to submit the bugfix separately, but if you must put them in one PR, mark the commit separately.
All changes must be code reviewed. Coding conventions and standards are explained in the official developer docs. Expect reviewers to request that you avoid common go style mistakes in your PRs.
Baremetal Operator will maintain older versions through release-X.Y branches.
We accept backports of bug fixes to the most recent
release branch. For example, if the most recent branch is release-0.3, and the
main branch is under active
development for v0.4.0, a bug fix that merged to main that also affects
v0.3.x may be considered for backporting
to release-0.3. We generally do not accept PRs against older release branches.
Breaking changes are generally allowed in the main branch.
There may be times, however, when main is closed for breaking changes. This
is likely to happen as we are close to release a new minor version.
Breaking changes are not allowed in release branches, as these represent minor versions that have already been released. These versions have consumers who expect the APIs, behaviors, etc. to remain stable during the life time of the patch stream for the minor release.
Examples of breaking changes include:
- Removing or renaming a field in a CRD
- Removing or renaming a CRD
- Removing or renaming an exported constant, variable, type, or function
- Updating the version of critical libraries such as controller-runtime, client-go, apimachinery, etc. (patch versions of these libraries are not considered as breaking change)
- Some version updates may be acceptable, for picking up bug fixes, but maintainers must exercise caution when reviewing.
There is possibility to have exceptions where breaking changes are allowed in
release branches. These are at the discretion of the project's maintainers, and
must be carefully considered before merging. An example of an allowed
breaking change might be a fix for a behavioral bug that was released in an
initial minor version (such as v0.3.0).
Please see the Kubernetes community document on pull requests for more information about the merge process.
To gain viewing permissions to google docs in this project, please join the metal3-dev google group.
Anyone may comment on issues and submit reviews for pull requests. However, in order to be assigned an issue or pull request, you must be a member of the Metal3-io organization GitHub organization.
Metal3 maintainers can assign you an issue or pull request by leaving a
/assign <your Github ID> comment on the issue or pull request.
Baremetal Operator follows the standard Kubernetes workflow: any PR
needs lgtm and approved labels, and PRs must pass the tests before being
merged. See
the contributor docs
for more info.
We use the same priority and kind labels as Kubernetes. See the labels tab in GitHub for the full list.
The standard Kubernetes comment commands should work in Baremetal Operator. See Prow for a command reference.
Minor and patch releases are generally done immediately after a feature or bugfix is landed, or sometimes a series of features tied together.
Minor releases will only be tagged on the most recent major release branch, except in exceptional circumstances. Patches will be backported to maintained stable versions, as needed.
Major releases will be done shortly after a breaking change is merged -- once a breaking change is merged, the next release must be a major revision. We don't intend to have a lot of these, so we may put off merging breaking PRs until a later date.
Refer to the releasing document for the exact steps.