Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LLDP collection in bmh #1731

Open
shibaPuppy opened this issue May 19, 2024 · 7 comments
Open

Add LLDP collection in bmh #1731

shibaPuppy opened this issue May 19, 2024 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@shibaPuppy
Copy link

User Story
since ironic allows you to configure LLDP collection, you should similarly be able to enter LLDP values ​​in bmh status.
see your network topology, understand the physical connections between devices, and troubleshoot more efficiently.

Detailed Description
since LLDP information is collected at the ironic inspection stage, I think it should be collected at the same timing as HardwareData.

Anything else you would like to add:
#1227

If a new CR (ex. network discovery) is created, will a new controller be needed?
when I looked at the code again recently, I thought that going similar to PR would be the easiest direction without any changes.

/kind feature

@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 19, 2024
@dtantsur
Copy link
Member

I'm generally in favour of this idea but I'd like a design proposal on it since it adds API. I'd rather not see API that simply exposes everything that Ironic collects as raw information.

@Rozzii
Copy link
Member

Rozzii commented May 29, 2024

/triage accepted
I will close #1227 in favor of this issue, create a design proposal first please in the metal3-docs repo.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 29, 2024
@shibaPuppy
Copy link
Author

shibaPuppy commented Jun 3, 2024

@dtantsur @Rozzii
I think it is reasonable to add LLDP content to the existing hardwareData.
do you think we need to add a new CR?
i think we can only start once this is decided.

@Rozzii
Copy link
Member

Rozzii commented Jun 4, 2024

I am fine with putting the LLDP data to the hardwareData, what about you @dtantsur ?

@dtantsur
Copy link
Member

It depends on how much you want to add, really. If it's just a couple of fields, I'm good with that.

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 8, 2024
@Rozzii
Copy link
Member

Rozzii commented Sep 11, 2024

/remove-lifecycle stale
/lifecycle frozen

@metal3-io-bot metal3-io-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Status: Backlog
Development

No branches or pull requests

4 participants