Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check nodes/BMHs in IP-reuse e2e test #1712

Open
lentzi90 opened this issue May 17, 2024 · 3 comments
Open

Check nodes/BMHs in IP-reuse e2e test #1712

lentzi90 opened this issue May 17, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@lentzi90
Copy link
Member

What steps did you take and what happened:

Currently the e2e test for IP-reuse is just checking the IPPool, not the nodes or BMHs.

What did you expect to happen:

We should extend the test to actually make sure that the IPAddresses are used, not just allocated in the IPPool. This may require a bit more changes to the tests actually, because I think we are currently only setting them in the metadata, not really using them in the networkdata.

Anything else you would like to add:

/kind feature
@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 17, 2024
@Rozzii
Copy link
Member

Rozzii commented May 29, 2024

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels May 29, 2024
@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 27, 2024
@Rozzii
Copy link
Member

Rozzii commented Aug 28, 2024

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Metal3 - Roadmap
Status: CAPM3 WIP
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lentzi90 @Rozzii @metal3-io-bot