Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node capacity check counts non-running pods #2582

Closed
aviramha opened this issue Jul 10, 2024 · 0 comments · Fixed by #2583
Closed

Node capacity check counts non-running pods #2582

aviramha opened this issue Jul 10, 2024 · 0 comments · Fixed by #2583

Comments

@aviramha
Copy link
Member

The node capacity check we have also counts non-running pods (completed jobs for example).

        let mut pod_count = 0;
        let mut list_params = ListParams {
            field_selector: Some(format!("spec.nodeName={}", self.node_name)),
            ..Default::default()
        };

probably need this status.phase=Running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't include non-running pods in node capacity check aviramha/mirrord
1 participant
@aviramha