Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue a warning to the user when their HTTP filter is preempted by another user #3120

Open
Razz4780 opened this issue Feb 25, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@Razz4780
Copy link
Contributor

Razz4780 commented Feb 25, 2025

HTTP filtering is a feature of mirrord that allows the user to steal only a subset of HTTP requests coming to the remote target (see reference here and here.

When the mirrord-agent captures a request, it compares it against HTTP filters from all connected clients here. It may happen that the request matches more than one filter. When this happens, only one of the clients receives the request, and the other clients don't even know it happened. We want to notify them about this event to improve the UX. For now, a simple warning should be enough.

Also, we'd like to have a new unit test for this logic (unless it turns out it's already covered by existing FilteredStealTask unit tests).

@Razz4780 Razz4780 added the enhancement New feature or request label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant