Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(URGENT, Firelight) Deployment of site requires index.html #303

Open
ronaldtse opened this issue Jan 13, 2025 · 12 comments
Open

(URGENT, Firelight) Deployment of site requires index.html #303

ronaldtse opened this issue Jan 13, 2025 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Jan 13, 2025

Right now the site is deployed to:

We have to go to these locations to see the documents:

(The documents work)

Screenshot 2025-01-13 at 1 26 27 PM Screenshot 2025-01-13 at 1 27 04 PM

You can see the contents of the uploaded artifact here:

We can provide a simple index.html which links to 001/index.html and 002/index.html.

Screenshot 2025-01-13 at 1 25 10 PM

FYI @ReesePlews

@ronaldtse ronaldtse added the bug Something isn't working label Jan 13, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Metanorma Jan 13, 2025
@ronaldtse ronaldtse moved this from 🆕 New to 🌋 Urgent in Metanorma Jan 13, 2025
@ReesePlews
Copy link
Contributor

thank you @ronaldtse i think this structure works well:

We have to go to these locations to see the documents:

https://metanorma.github.io/mn-samples-plateau/001/
https://metanorma.github.io/mn-samples-plateau/002/

on this page (https://www.mlit.go.jp/plateau/libraries/handbooks/) can these two URLs above be replaced for
https://www.mlit.go.jp/plateaudocument/
and
https://www.mlit.go.jp/plateaudocument02/
respectively?

or does the index.html (in both fl sites) need to be created as you have indicated here? and once the index.html exists it could be placed into those locations on the "...libraries/handbooks" page?

@ronaldtse
Copy link
Contributor Author

on this page (https://www.mlit.go.jp/plateau/libraries/handbooks/) can these two URLs above be replaced for https://www.mlit.go.jp/plateaudocument/ and https://www.mlit.go.jp/plateaudocument02/ respectively?

Yes, a direct replacement would work.

or does the index.html (in both fl sites) need to be created as you have indicated here? and once the index.html exists it could be placed into those locations on the "...libraries/handbooks" page?

We don't need an index.html if they want to use separate paths.

@ReesePlews
Copy link
Contributor

yes, i assume the end user will keep the current page layout (handbooks page), so being able to have separate paths for each fl "site" seems easiest. this could work well if they are keeping mn-samples-plateau in the current repo. at some point that repo may be changing, but that is not a question we need to answer at this time. i dont believe it would need to be moved before the final delivery, in fact i would advise against such changes until the project is completed (acceptance from the end user).

since the fl sites are updating upon each "site generate" GHA build that is really nice. i will discuss with the team.

@ReesePlews
Copy link
Contributor

sorry i need to reconfirm the links,

a) last week the links were:

https://metanorma.github.io/mn-samples-plateau-firelight-demo/001//
https://metanorma.github.io/mn-samples-plateau-firelight-demo/002//

b) with this new deployment GHA the links are now (as listed above) correct?

https://metanorma.github.io/mn-samples-plateau/001/
https://metanorma.github.io/mn-samples-plateau/002/

if the links at a) are no longer being updated can we removed them?

@ReesePlews
Copy link
Contributor

given this new issue #304 perhaps it is better to keep the links in a) active?

@ronaldtse
Copy link
Contributor Author

@ReesePlews the first set of links are not dynamically updated and will not be fixed anymore. We should remove them and I will delete the repository.

@ronaldtse
Copy link
Contributor Author

@ReesePlews also, the 002 issue is not a new one.

@ReesePlews
Copy link
Contributor

@ReesePlews also, the 002 issue is not a new one.

not sure what this means, but perhaps it is related to issue #304. for now i dont have any additional comments on this. thank you.

@strogonoff
Copy link
Contributor

b) with this new deployment GHA the links are now (as listed above) correct?

https://metanorma.github.io/mn-samples-plateau/001/ https://metanorma.github.io/mn-samples-plateau/002/

These are the new document links currently being updated.

@ReesePlews
Copy link
Contributor

thank you @strogonoff yes, those are the links have been using and discussing with the client.

re-reading this issue and comments, for the Plateau Project, a single index.html file is not needed. however for other projects it could be helpful, i guess it would depend on the project.

@ReesePlews
Copy link
Contributor

when i do access those links, i notice that a "//" is automatically added to the URL a couple of seconds after the page loads in the browser. the "//" is not there in the beginning when you visit the page but it appears a couple of seconds later. @strogonoff if you think this should be a new issue, please let me know, though not a priority.

@strogonoff
Copy link
Contributor

strogonoff commented Jan 31, 2025

Yes, the double-slash is a known bug (though it doesn’t break the site): metanorma/firelight#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🌋 Urgent
Development

No branches or pull requests

3 participants