-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(URGENT, Firelight) Deployment of site requires index.html
#303
Comments
thank you @ronaldtse i think this structure works well:
on this page (https://www.mlit.go.jp/plateau/libraries/handbooks/) can these two URLs above be replaced for or does the index.html (in both fl sites) need to be created as you have indicated here? and once the index.html exists it could be placed into those locations on the "...libraries/handbooks" page? |
Yes, a direct replacement would work.
We don't need an |
yes, i assume the end user will keep the current page layout (handbooks page), so being able to have separate paths for each fl "site" seems easiest. this could work well if they are keeping mn-samples-plateau in the current repo. at some point that repo may be changing, but that is not a question we need to answer at this time. i dont believe it would need to be moved before the final delivery, in fact i would advise against such changes until the project is completed (acceptance from the end user). since the fl sites are updating upon each "site generate" GHA build that is really nice. i will discuss with the team. |
sorry i need to reconfirm the links, a) last week the links were: https://metanorma.github.io/mn-samples-plateau-firelight-demo/001// b) with this new deployment GHA the links are now (as listed above) correct? https://metanorma.github.io/mn-samples-plateau/001/ if the links at a) are no longer being updated can we removed them? |
given this new issue #304 perhaps it is better to keep the links in a) active? |
@ReesePlews the first set of links are not dynamically updated and will not be fixed anymore. We should remove them and I will delete the repository. |
@ReesePlews also, the 002 issue is not a new one. |
not sure what this means, but perhaps it is related to issue #304. for now i dont have any additional comments on this. thank you. |
These are the new document links currently being updated. |
thank you @strogonoff yes, those are the links have been using and discussing with the client. re-reading this issue and comments, for the Plateau Project, a single index.html file is not needed. however for other projects it could be helpful, i guess it would depend on the project. |
when i do access those links, i notice that a "//" is automatically added to the URL a couple of seconds after the page loads in the browser. the "//" is not there in the beginning when you visit the page but it appears a couple of seconds later. @strogonoff if you think this should be a new issue, please let me know, though not a priority. |
Yes, the double-slash is a known bug (though it doesn’t break the site): metanorma/firelight#19 |
Right now the site is deployed to:
We have to go to these locations to see the documents:
(The documents work)
You can see the contents of the uploaded artifact here:
We can provide a simple index.html which links to 001/index.html and 002/index.html.
FYI @ReesePlews
The text was updated successfully, but these errors were encountered: