Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Shanking SPL Programs #26

Open
lorisleiva opened this issue Jun 21, 2022 · 4 comments
Open

Consider Shanking SPL Programs #26

lorisleiva opened this issue Jun 21, 2022 · 4 comments

Comments

@lorisleiva
Copy link

This is just an issue to log the fact that having Shank-generated IDLs and autogenerated libraries for SPL programs would be very valuable.

Not sure how we would go about it since we'd need to clone the programs, add shank and then maintain all future updates but maybe there's another way I don't see.

Priority for SDKs: Low (Nice-To-Have).

@thlorenz
Copy link
Contributor

100% agree should maybe file a related issue/question in the repo housing those programs to see if this is desired there.

@ngundotra
Copy link
Contributor

ngundotra commented Aug 18, 2022

I agree as well. Working on adding shank to SPL gov here: https://github.com/solana-labs/solana-program-library/pull/3494/files

One of the issues is that Shank restricts Instructions to have only 1 argument.

Is this an insurmountable technical restraint, or can I just hack at the macro to get this working?

@thlorenz
Copy link
Contributor

Hey I think you did just hack at the macro and now this is no longer an issue right @ngundotra ? See #32.
If that solved that issue what else stands in the way of shanking SPL programs so we can address them?

@ngundotra
Copy link
Contributor

ngundotra commented Sep 22, 2022

I'll try out shanking some other programs, but I think this will largely fall under the maintainer's discretion.

The nice win here for Labs would be standardization of all our TS SDKs however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants