cli: fix jstp import statement, fixes #129 #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
requested changes
May 5, 2017
tools/cli.js
Outdated
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| // TODO: support jstp://server and jstps://server | |||
|
|
|||
| const jstp = require('.'); | |||
| const jstp = require('../'); | |||
There was a problem hiding this comment.
Can you please remove the trailing slash?
|
@lundibundi and I don't think it is required to request reviews explicitly for such a trivial change ;) Basically, you've stated that this PR cannot land until both I and @belochub approve it. |
lundibundi
force-pushed
the
fix-jstp-import-in-cli
branch
from
7a9d0a9
to
55577eb
Compare
|
@aqrln ok, done |
|
Landed in a688994, thanks! |
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
PR-URL: metarhia/jstp#130 Fixes: metarhia/jstp#129 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
PR-URL: metarhia/jstp#130 Fixes: metarhia/jstp#129 Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.