Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: add import/no-unresolved ESLint rule #133

Closed
wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented May 5, 2017

I am planning to rearrange the structure of lib a little bit, so I decided to add this rule to be safe doing this. And it is a nice thing to have generally.

@aqrln aqrln added the test label May 5, 2017
Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aqrln
Copy link
Member Author

aqrln commented May 5, 2017

@belochub btw, heads up, you need to do npm install -g eslint-plugin-import in order for it to work in Vim. The syntastic plugin works with the global ESLint installation.

aqrln added a commit that referenced this pull request May 5, 2017
PR-URL: #133
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@aqrln
Copy link
Member Author

aqrln commented May 5, 2017

Landed in 06579df.

@aqrln aqrln closed this May 5, 2017
@aqrln aqrln deleted the eslint-resolve-modules branch May 5, 2017 19:25
aqrln added a commit to metarhia/eslint-config-metarhia that referenced this pull request Sep 6, 2017
Original commit:
metarhia/jstp@06579df

Original commit message:

  lint: add import/no-unresolved ESLint rule

  PR-URL: metarhia/jstp#133
  Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #133
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #133
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
@belochub belochub mentioned this pull request Jan 22, 2018
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
PR-URL: metarhia/jstp#133
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 19, 2018
PR-URL: metarhia/jstp#133
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub pushed a commit to metarhia/mdsf that referenced this pull request Jul 21, 2018
PR-URL: metarhia/jstp#133
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants