-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: add import/no-unresolved ESLint rule #133
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belochub
approved these changes
May 5, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@belochub btw, heads up, you need to do |
aqrln
added a commit
that referenced
this pull request
May 5, 2017
PR-URL: #133 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Landed in 06579df. |
aqrln
added a commit
to metarhia/eslint-config-metarhia
that referenced
this pull request
Sep 6, 2017
Original commit: metarhia/jstp@06579df Original commit message: lint: add import/no-unresolved ESLint rule PR-URL: metarhia/jstp#133 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #133 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
PR-URL: #133 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
PR-URL: metarhia/jstp#133 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
PR-URL: metarhia/jstp#133 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 21, 2018
PR-URL: metarhia/jstp#133 Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am planning to rearrange the structure of
lib
a little bit, so I decided to add this rule to be safe doing this. And it is a nice thing to have generally.