cli: refine error messages #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lundibundi
commented
May 6, 2017
lundibundi
commented
- make all missing argument errors conform to single style
- report error on missing host/port, {method,event} name
belochub
reviewed
May 6, 2017
| } | ||
| const args = _split(tokens, ' ', 2); | ||
| const [host, port] = _split(args[0], ':'); | ||
| if (port === undefined) { |
There was a problem hiding this comment.
Here host can be undefined as well.
* make all missing argument errors conform to single style
* report error on missing host/port, {method,event} name
lundibundi
force-pushed
the
refine-input-errors
branch
from
a06f8c6
to
6037b5b
Compare
belochub
pushed a commit
that referenced
this pull request
May 6, 2017
* Make all missing argument errors conform to single style.
* Report error on missing host/port, {method,event} name.
PR-URL: #135
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
|
Landed in 3c039d2. |
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
* Make all missing argument errors conform to single style.
* Report error on missing host/port, {method,event} name.
PR-URL: #135
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
that referenced
this pull request
Jan 22, 2018
* Make all missing argument errors conform to single style.
* Report error on missing host/port, {method,event} name.
PR-URL: #135
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Merged
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
* Make all missing argument errors conform to single style.
* Report error on missing host/port, {method,event} name.
PR-URL: metarhia/jstp#135
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
belochub
pushed a commit
to metarhia/mdsf
that referenced
this pull request
Jul 19, 2018
* Make all missing argument errors conform to single style.
* Report error on missing host/port, {method,event} name.
PR-URL: metarhia/jstp#135
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Mykola Bilochub <nbelochub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.