-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update badges in README.md and doc/index.md #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listed con is not really a con (at least for me) 😄
LGTM.
@tshemsedinov what's the status of this and metarhia/Metarhia#3? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to propose:
- BitHound score:
[![bitHound](https://www.bithound.io/github/metarhia/JSTP/badges/score.svg)](https://www.bithound.io/github/metarhia/JSTP)
- NPM version using badge.fury.io
[![NPM Version](https://badge.fury.io/js/metarhia-jstp.svg)](https://badge.fury.io/js/metarhia-jstp)
@tshemsedinov +1 for the BitHound score. What about the second proposal, |
Travis CI and bitHound badges in `README.md` are now included directly. NPM downloads stats badges are left with <shields.io> since there are no official badges from NPM itself and these were generated by <shields.io>, not included from an external service. Yet their style is changed to match the first two ones. NPM version badge is now included from <badge.fury.io>. Badges in `doc/index.md` are now synchronized with badges in `README.md` since they weren't updated last time when they were changed in `README.md`. Refs: metarhia/Metarhia#3
@tshemsedinov I updated the commit to address the suggestions. Does this LGTY? |
Travis CI and bitHound badges in `README.md` are now included directly. NPM downloads stats badges are left with <shields.io> since there are no official badges from NPM itself and these were generated by <shields.io>, not included from an external service. Yet their style is changed to match the first two ones. NPM version badge is now included from <badge.fury.io>. Badges in `doc/index.md` are now synchronized with badges in `README.md` since they weren't updated last time when they were changed in `README.md`. Refs: metarhia/Metarhia#3 PR-URL: #71
Landed in 28fcd10. |
Travis CI and bitHound badges in `README.md` are now included directly. NPM downloads stats badges are left with <shields.io> since there are no official badges from NPM itself and these were generated by <shields.io>, not included from an external service. Yet their style is changed to match the first two ones. NPM version badge is now included from <badge.fury.io>. Badges in `doc/index.md` are now synchronized with badges in `README.md` since they weren't updated last time when they were changed in `README.md`. Refs: metarhia/Metarhia#3 PR-URL: #71
Travis CI and bitHound badges in `README.md` are now included directly. NPM downloads stats badges are left with <shields.io> since there are no official badges from NPM itself and these were generated by <shields.io>, not included from an external service. Yet their style is changed to match the first two ones. NPM version badge is now included from <badge.fury.io>. Badges in `doc/index.md` are now synchronized with badges in `README.md` since they weren't updated last time when they were changed in `README.md`. Refs: metarhia/Metarhia#3 PR-URL: #71
Travis CI and bitHound badges in `README.md` are now included directly. NPM downloads stats badges are left with <shields.io> since there are no official badges from NPM itself and these were generated by <shields.io>, not included from an external service. Yet their style is changed to match the first two ones. NPM version badge is now included from <badge.fury.io>. Badges in `doc/index.md` are now synchronized with badges in `README.md` since they weren't updated last time when they were changed in `README.md`. Refs: metarhia/Metarhia#3 PR-URL: #71
Travis CI and bitHound badges in `README.md` are now included directly. NPM downloads stats badges are left with <shields.io> since there are no official badges from NPM itself and these were generated by <shields.io>, not included from an external service. Yet their style is changed to match the first two ones. NPM version badge is now included from <badge.fury.io>. Badges in `doc/index.md` are now synchronized with badges in `README.md` since they weren't updated last time when they were changed in `README.md`. Refs: metarhia/Metarhia#3 PR-URL: #71
Travis CI and bitHound badges in
README.md
are now included directly.NPM badges are left with <shields.io> since there are no official badges
from NPM itself and these were generated by <shields.io>, not included
from an external service. Yet their style is changed to match the first
two ones. Badges in
doc/index.md
are now synchronized with badges inREADME.md
since they weren't updated last time when they were changedin
README.md
.Refs: metarhia/Metarhia#3
Pro: more stable badge loading.
Con: badges aren't flat anymore.