Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update badges in README.md and doc/index.md #71

Closed
wants to merge 1 commit into from
Closed

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Feb 11, 2017

Travis CI and bitHound badges in README.md are now included directly.
NPM badges are left with <shields.io> since there are no official badges
from NPM itself and these were generated by <shields.io>, not included
from an external service. Yet their style is changed to match the first
two ones. Badges in doc/index.md are now synchronized with badges in
README.md since they weren't updated last time when they were changed
in README.md.

Refs: metarhia/Metarhia#3

Pro: more stable badge loading.
Con: badges aren't flat anymore.

Copy link
Member

@belochub belochub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listed con is not really a con (at least for me) 😄
LGTM.

@aqrln
Copy link
Member Author

aqrln commented Feb 14, 2017

@tshemsedinov what's the status of this and metarhia/Metarhia#3?

Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to propose:

  1. BitHound score:
[![bitHound](https://www.bithound.io/github/metarhia/JSTP/badges/score.svg)](https://www.bithound.io/github/metarhia/JSTP)
  1. NPM version using badge.fury.io
[![NPM Version](https://badge.fury.io/js/metarhia-jstp.svg)](https://badge.fury.io/js/metarhia-jstp)

@aqrln
Copy link
Member Author

aqrln commented Feb 15, 2017

@tshemsedinov +1 for the BitHound score. What about the second proposal, badge.fury.io only provides version badges and we will either still need shields.io for downloads stats or have to remove them completely. An alternative is NodeICO which is very stable since it is a NodeSource-backed project, not someone's hobby project with a couple of servers like shields.io, but its style is completely inconsistent with other badges.

Travis CI and bitHound badges in `README.md` are now included directly.
NPM downloads stats badges are left with <shields.io> since there are no
official badges from NPM itself and these were generated by
<shields.io>, not included from an external service. Yet their style is
changed to match the first two ones.  NPM version badge is now included
from <badge.fury.io>.  Badges in `doc/index.md` are now synchronized
with badges in `README.md` since they weren't updated last time when
they were changed in `README.md`.

Refs: metarhia/Metarhia#3
@aqrln
Copy link
Member Author

aqrln commented Feb 19, 2017

@tshemsedinov I updated the commit to address the suggestions. Does this LGTY?

aqrln added a commit that referenced this pull request Feb 19, 2017
Travis CI and bitHound badges in `README.md` are now included directly.
NPM downloads stats badges are left with <shields.io> since there are no
official badges from NPM itself and these were generated by
<shields.io>, not included from an external service. Yet their style is
changed to match the first two ones.  NPM version badge is now included
from <badge.fury.io>.  Badges in `doc/index.md` are now synchronized
with badges in `README.md` since they weren't updated last time when
they were changed in `README.md`.

Refs: metarhia/Metarhia#3
PR-URL: #71
@aqrln
Copy link
Member Author

aqrln commented Feb 19, 2017

Landed in 28fcd10.

@aqrln aqrln closed this Feb 19, 2017
@aqrln aqrln deleted the raw-badges branch February 19, 2017 01:38
aqrln added a commit that referenced this pull request Feb 20, 2017
Travis CI and bitHound badges in `README.md` are now included directly.
NPM downloads stats badges are left with <shields.io> since there are no
official badges from NPM itself and these were generated by
<shields.io>, not included from an external service. Yet their style is
changed to match the first two ones.  NPM version badge is now included
from <badge.fury.io>.  Badges in `doc/index.md` are now synchronized
with badges in `README.md` since they weren't updated last time when
they were changed in `README.md`.

Refs: metarhia/Metarhia#3
PR-URL: #71
@aqrln aqrln mentioned this pull request Feb 20, 2017
aqrln added a commit that referenced this pull request Feb 20, 2017
Travis CI and bitHound badges in `README.md` are now included directly.
NPM downloads stats badges are left with <shields.io> since there are no
official badges from NPM itself and these were generated by
<shields.io>, not included from an external service. Yet their style is
changed to match the first two ones.  NPM version badge is now included
from <badge.fury.io>.  Badges in `doc/index.md` are now synchronized
with badges in `README.md` since they weren't updated last time when
they were changed in `README.md`.

Refs: metarhia/Metarhia#3
PR-URL: #71
belochub pushed a commit that referenced this pull request Jan 22, 2018
Travis CI and bitHound badges in `README.md` are now included directly.
NPM downloads stats badges are left with <shields.io> since there are no
official badges from NPM itself and these were generated by
<shields.io>, not included from an external service. Yet their style is
changed to match the first two ones.  NPM version badge is now included
from <badge.fury.io>.  Badges in `doc/index.md` are now synchronized
with badges in `README.md` since they weren't updated last time when
they were changed in `README.md`.

Refs: metarhia/Metarhia#3
PR-URL: #71
belochub pushed a commit that referenced this pull request Jan 22, 2018
Travis CI and bitHound badges in `README.md` are now included directly.
NPM downloads stats badges are left with <shields.io> since there are no
official badges from NPM itself and these were generated by
<shields.io>, not included from an external service. Yet their style is
changed to match the first two ones.  NPM version badge is now included
from <badge.fury.io>.  Badges in `doc/index.md` are now synchronized
with badges in `README.md` since they weren't updated last time when
they were changed in `README.md`.

Refs: metarhia/Metarhia#3
PR-URL: #71
@belochub belochub mentioned this pull request Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants