Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palm rejection needed #16

Open
dmurfet opened this issue Dec 25, 2021 · 7 comments
Open

Palm rejection needed #16

dmurfet opened this issue Dec 25, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@dmurfet
Copy link
Member

dmurfet commented Dec 25, 2021

At the moment most users of the boards will have problems with "stray dots" or "stray lines" most likely generated by the lack of palm rejection. There may not be a perfect answer here, e.g. GoodNotes allows the user to configure how much palm rejection to do in software https://support.goodnotes.com/hc/en-us/articles/360000129755-Configuring-palm-rejection-in-GoodNotes-5.

@dmurfet
Copy link
Member Author

dmurfet commented Jan 13, 2022

The lack of even basic palm rejection was a problem in several sessions on 13-1-22, particularly in the morning Foundations and evening Cryptography sessions.

@ecurtiss ecurtiss added the enhancement New feature or request label Jan 27, 2022
@dmurfet
Copy link
Member Author

dmurfet commented Jan 29, 2022

I don't actually have this problem under normal usage, but I can reproduce it by tapping the screen simultaneously with my left index finger and the Apple Pencil held in my right hand, to create the lines you see in the first image below

IMG_0245

With the simple palm rejection added in ec915c2 most of these long lines are rejected (the rejection threshold is 100 pixels)

IMG_0246

This isn't perfect, but observing our speakers in practice they usually generate lines longer than 100 pixels, because the distance from their pen tip to whatever part of their palm is triggering the touch event is further than that. I believe this simple fix will eliminate > 80% of occurrences. However, a smarter solution on top of this would be great.

@dmurfet
Copy link
Member Author

dmurfet commented Feb 4, 2022

I'm closing this for now, we can worry about improved palm rejection later.

@dmurfet dmurfet closed this as completed Feb 4, 2022
@dmurfet dmurfet reopened this Feb 10, 2022
@dmurfet
Copy link
Member Author

dmurfet commented Feb 10, 2022

Screen Shot 2022-02-10 at 7 25 29 am

This line is in the range we would expect to still be possible, but was generated "naturally" during an event. So we still need a better system for palm rejection.

@dmurfet
Copy link
Member Author

dmurfet commented Feb 10, 2022

I think we should pay attention not only to "palm lines" but also "palm dots" which are now a bigger problem.

@blinkybool
Copy link
Member

Meeting suggestion: Halve the threshold

@blinkybool
Copy link
Member

The multi-touch lines are gone now. All that's left is the dots drawn by your palm while your pen is lifted (dots while pen is down are gone).

Getting rid of those palm dots is less trivial - you need to track the historical positions of strokes and estimate the likelihood of a new touch appearing far away from them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants