Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LaunchScreen from web clients #10702

Closed
mitar opened this issue Sep 23, 2019 · 7 comments · Fixed by #11371
Closed

Remove LaunchScreen from web clients #10702

mitar opened this issue Sep 23, 2019 · 7 comments · Fixed by #11371
Labels
confirmed We want to fix or implement it good first issue Good first issue or something that should is nice to do.
Milestone
Release 2.3

Comments

@mitar
Copy link
Contributor

mitar commented Sep 23, 2019

LaunchScreen is really used just on Cordova. For web clients it contains some code, but the code is just a placeholder and it looks even that it is expected just to work with Blaze.

I would simply remove all that code for the client as it is just adding weight to the bundle.

Moreover, effective loading screens on the web have to be made into static HTML content rendered by the server anyway, so that they can be shown even before JavaScript starts loading. So it cannot be made in JavaScript, to show the loading of primarily JavaScript.

Tested on Meteor 1.8.1.
@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Dec 10, 2019
@mitar
Copy link
Contributor Author

mitar commented Dec 10, 2019

Still relevant.

@stale stale bot removed the stale-bot label Dec 10, 2019
@mitar mitar mentioned this issue Dec 10, 2019
Merged
@filipenevola filipenevola added the confirmed We want to fix or implement it label Dec 11, 2019
@stale
Copy link

stale bot commented Oct 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Oct 31, 2020
@mitar
Copy link
Contributor Author

mitar commented Oct 31, 2020

Still relevant.

@stale stale bot removed the stale-bot label Oct 31, 2020
@StorytellerCZ StorytellerCZ added the good first issue Good first issue or something that should is nice to do. label Apr 2, 2021
@StorytellerCZ StorytellerCZ mentioned this issue Apr 3, 2021
Merged
@StorytellerCZ StorytellerCZ linked a pull request Apr 3, 2021 that will close this issue
Make launch-screen only for Cordova & update plugin #11371
Merged
@StorytellerCZ
Copy link
Collaborator

@mitar please check #11371 if that is what you had in mind.

@mitar
Copy link
Contributor Author

mitar commented Apr 5, 2021

Awesome!

@StorytellerCZ
Copy link
Collaborator

Will be released together with Meteor 2.3

@StorytellerCZ StorytellerCZ added this to the Release 2.3 milestone May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed We want to fix or implement it good first issue Good first issue or something that should is nice to do.
Projects
None yet
Milestone
Release 2.3
Development

Successfully merging a pull request may close this issue.

Make launch-screen only for Cordova & update plugin meteor/meteor
3 participants
@filipenevola @mitar @StorytellerCZ