Assure that transform is not changing cached object #2231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitar
added a commit
to peerlibrary/meteor-peerdb
that referenced
this pull request
Jun 12, 2014
This reverts commit 09db486. This is not necessary after this bugfix in Meteor: meteor/meteor#2231
|
Good catch. It would be more consistent with the rest of the file to move the EJSON.clone into the transform call (and that would make it more clear that the clone is for transform's sake). |
|
OK, I was thinking you'd update the PR based on my comment, but I did it myself and merged it. Thanks! |
|
Oh, sorry. :-( |
|
Should there be tests made for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2026.