Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units are not user-definable and are not used consistently #1223

Open
2 tasks
heikoklein opened this issue Jun 24, 2024 · 0 comments
Open
2 tasks

Units are not user-definable and are not used consistently #1223

heikoklein opened this issue Jun 24, 2024 · 0 comments
Labels
bug 🐛 Something isn't working

Comments

@heikoklein
Copy link
Member

Describe the bug
In pyaerocom up to current versions, units are hard-coded in variables.ini and are not user-definable. These units are used for model-input and thus the geojson contourplots on aeroval.
For collocation, the units from the measurements are used.

This makes can make units inconsistent, i.e. when plotting stations on top of contours. It might also make units inconsistent when showing All measurments at once, i.e. when different measurement-networks use different units.

To Reproduce
Steps to reproduce the behavior:

  1. change units in variables.ini
  2. plot contours
  3. show contours with obs under Maps in aeroval

Expected behavior

  • The units from variables.ini should be used for both contours and measurements.
  • A modeller should be able to provide a variables.ini file overwriting the default values

Additional context

@heikoklein heikoklein added the bug 🐛 Something isn't working label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant