Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement country filtering for 4D colocated data sets #1295

Open
lewisblake opened this issue Aug 1, 2024 · 0 comments
Open

Implement country filtering for 4D colocated data sets #1295

lewisblake opened this issue Aug 1, 2024 · 0 comments
Labels
enhancement ✨ New feature or request SESAM Issues related to the SESAM project

Comments

@lewisblake
Copy link
Member

lewisblake commented Aug 1, 2024

Is your feature request related to a problem? Please describe.
Country filtering is not implemented for 4D colocated data sets.

elif coldata.has_latlon_dims and regions_how == "country":
raise NotImplementedError(
"Cannot yet apply country filtering for 4D colocated data instances"

4D colocated data sets are defined as

cf :func:`pyaerocom.colocation.colocate_gridded_ungridded`) while 4D
colocated data is created when a model is colocated with another model or
satellite observations, that cover large parts of Earth's surface (other
than discrete lat/lon pairs in the case of ground based station locations).

Describe the solution you would like to see
I would like this implemented. Needed for satellite data comparisions, e.g., in SESAM.

  • Would you be able to work on this solution yourself? kanskje
  • How can the Pyaerocom development team assist you? hjelp

Additional context
Regions in general need an overhaul, but this is a smaller feature which would be very helpful for satellite data comparisons. It isn't obvious to me why this is an issue, but the devil is in the details. This is what such a ColocatedData instance looks like:

Screenshot from 2024-08-01 20-28-39

@lewisblake lewisblake added enhancement ✨ New feature or request SESAM Issues related to the SESAM project labels Aug 1, 2024
@lewisblake lewisblake mentioned this issue Aug 2, 2024
9 tasks
@lewisblake lewisblake modified the milestone: m2024-10 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request SESAM Issues related to the SESAM project
Projects
None yet
Development

No branches or pull requests

1 participant