Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region(s) should stored as an array #580

Closed
AugustinMortier opened this issue Feb 3, 2022 · 3 comments · Fixed by #582
Closed

region(s) should stored as an array #580

AugustinMortier opened this issue Feb 3, 2022 · 3 comments · Fixed by #582
Assignees
Labels
aeroval-tools Issues related to AeroVal web tools bug 🐛 Something isn't working

Comments

@AugustinMortier
Copy link
Member

In AeroVal map json files (e.g: AeronetL1.5-d-od550aer_Column_IFS-CTRL-od550aer.json ) each station has a "region" key whose value is a string.

However, a station could belong to more than one region: e.g Ocean, and North-America.

This problem can be seen with the new AeroVal minimap feature. When selecting North-America, no station is highlighted since they all belong to "Oceans" (might be also a bug here).

minimaps

@AugustinMortier AugustinMortier added the bug 🐛 Something isn't working label Feb 3, 2022
@AugustinMortier AugustinMortier added the aeroval-tools Issues related to AeroVal web tools label Feb 3, 2022
@jgriesfeller jgriesfeller linked a pull request Mar 1, 2022 that will close this issue
@jgriesfeller
Copy link
Member

jgriesfeller commented Mar 1, 2022

Just for the record: due to expected running time of the linked experiment, I chose to re-run the 2021 only experiment for now. I hope that suffices for testing. The experiment is running now and I will inform you when it's finished.
The eval experiment might need more than a day to run because it's quite large. Please let me know if it has to be the eval experiment.

@jgriesfeller
Copy link
Member

I introduced a testing project on the web server that is only accessible if you know the URL:
https://aeroval.met.no/evaluation.php?project=testing

It has the regions in an array, but the error mentioned above persists.

@AugustinMortier
Copy link
Member Author

The AeroVal minimap now can highlight stations belonging to different regions. I think this issue is solved then. Thanks!

Screenshot from 2022-03-03 16-47-57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aeroval-tools Issues related to AeroVal web tools bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants