Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

malli.swagger generates null definitions #1134

Closed
jkxyz opened this issue Nov 25, 2024 · 2 comments · Fixed by #1136
Closed

malli.swagger generates null definitions #1134

jkxyz opened this issue Nov 25, 2024 · 2 comments · Fixed by #1136
Labels
bug Something isn't working

Comments

@jkxyz
Copy link

jkxyz commented Nov 25, 2024

The following line in malli.swagger always sets :definitions to nil. This causes some validations of the Swagger definition to fail (in my case, Microsoft Power Automate doesn't accept it). It should only update the :definitions key if any definitions are present.

(update :definitions merge definitions)

@opqdonut opqdonut added the bug Something isn't working label Nov 26, 2024
@opqdonut
Copy link
Member

Thanks for noticing that! Should be easy to fix – I'm working on it.

@jkxyz
Copy link
Author

jkxyz commented Nov 26, 2024

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants