Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user_id for sending metrics #88

Open
tilsche opened this issue Mar 22, 2021 · 3 comments
Open

Set user_id for sending metrics #88

tilsche opened this issue Mar 22, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@tilsche
Copy link
Contributor

tilsche commented Mar 22, 2021

For debugging purposes it would be helpful to be able to determine the sender of a message. This requires setting the user_id in the sender itself (see https://adam.younglogic.com/2016/03/id-sender-rabbitmq/).

We should at least check if this has a significant performance cost given our current message rates.

@phijor
Copy link
Contributor

phijor commented Mar 22, 2021

aio_pika.Message supports setting a user ID; and we could parse the current user from Agent._management_url, correct?

@tilsche
Copy link
Contributor Author

tilsche commented Mar 22, 2021

The amqp user may not be unique, the token would be better. We may eventually check that with respect to security though (as we initially intended tokens to be eventually secret).

@kinnarr
Copy link
Member

kinnarr commented Jul 21, 2021

The user_id must be the amqp user.

data channel error: PRECONDITION_FAILED - user_id property set to 'source-stress-test' but authenticated user was 'admin'

We could instead use appID like in Db::on_history.

@bmario bmario added the enhancement New feature or request label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants