Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 32-bit architectures? #235

Closed
jszwedko opened this issue Oct 15, 2021 · 1 comment · Fixed by #313
Closed

Support for 32-bit architectures? #235

jszwedko opened this issue Oct 15, 2021 · 1 comment · Fixed by #313
Labels
C-core Component: core functionality such as traits, etc. C-exporter Component: exporters such as Prometheus, TCP, etc. C-macros Component: macros. C-util Component: utility classes and helpers. E-simple Effort: simple. T-enhancement Type: enhancement.

Comments

@jszwedko
Copy link
Contributor

It looks like currently this crate doesn't build on powerpc-unknown-linux-gnu:

➜  metrics git:(main) cargo build --target=powerpc-unknown-linux-gnu
   Compiling serde v1.0.130
   Compiling prost v0.7.0
   Compiling tracing v0.1.29
   Compiling thiserror v1.0.30
   Compiling metrics v0.17.0 (/home/jesse/workspace/metrics/metrics)
error[E0432]: unresolved import `std::sync::atomic::AtomicU64`
 --> metrics/src/key.rs:7:32
  |
7 |     sync::atomic::{AtomicBool, AtomicU64, Ordering},
  |                                ^^^^^^^^^
  |                                |
  |                                no `AtomicU64` in `sync::atomic`
  |                                help: a similar name exists in the module: `AtomicU8`

error: aborting due to previous error

We discovered this by way of a user trying to compile vector for powerpc-unknown-linux-gnu.

Is this a platform this crate would be interested in supporting? I imagine this would mean generally supporting 32-bit architectures.

@tobz
Copy link
Member

tobz commented Oct 15, 2021

No issue with trying to support them, nope!

Likely just need to do something like this across the entire crate.

@tobz tobz added C-core Component: core functionality such as traits, etc. C-exporter Component: exporters such as Prometheus, TCP, etc. C-macros Component: macros. C-util Component: utility classes and helpers. E-simple Effort: simple. T-enhancement Type: enhancement. labels Oct 15, 2021
@tobz tobz closed this as completed in #313 Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-core Component: core functionality such as traits, etc. C-exporter Component: exporters such as Prometheus, TCP, etc. C-macros Component: macros. C-util Component: utility classes and helpers. E-simple Effort: simple. T-enhancement Type: enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants