stop downloading the app asynchronously #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that the schema.ResourceData is not thread safe, even for concurrent reads, due to internal memoization during reads. The result was that app creation would sometimes fail mysteriously with an "unexpected EOF" error due to the provider process crashing due to either concurrent map writes or read/write.
Conflicts: cloudfoundry/resource_cf_app.go
If the PR is not applied, after running this test many times, it should crash with this error === RUN TestAccApp_reproduceIssue88 Application downloaded to: ../tests/cf-acceptance-tests/assets/java-spring/ Application downloaded to: ../tests/cf-acceptance-tests/assets/java-spring/ fatal error: concurrent map read and map write goroutine 1542 [running]: ... created by github.com/terraform-providers/terraform-provider-cf/cloudfoundry.resourceAppCreate .../golang/src/github.com/terraform-providers/terraform-provider-cf/cloudfoundry/resource_cf_app.go:421 +0x1ac4 # Conflicts: # cloudfoundry/resource_cf_app_test.go
Conflicts: cloudfoundry/resource_cf_app.go
jcarrothers-sap
requested review from
mevansam,
psycofdj,
gberche-orange,
ArthurHlt and
janosbinder
|
This PR replaces #103 |
gberche-orange
approved these changes
Sep 14, 2018
|
This was an ugly bug, which this PR fixes. We have deployed it internally and helped us. My tests takes longs to run, so I have nothing against, if we exclude it later. I wanted to provide the tests as a proof-of-concept to reproduce the bug. |
janosbinder
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88