Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance]: Memory Leak of Client Player #3794

Closed
pietro-lopes opened this issue Oct 3, 2024 · 1 comment
Closed

[Performance]: Memory Leak of Client Player #3794

pietro-lopes opened this issue Oct 3, 2024 · 1 comment
Labels

Comments

@pietro-lopes
Copy link

Steps to Reproduce the Bug

private @Nullable IRecipeLayoutList cachedRecipeLayoutsWithButtons;

  1. Load a world
  2. Open Jei
  3. Change dimensions

image

Expected Behavior

Cached objects that contain ClientPlayer should have a cleanup/update logic as ClientPlayer is discarded on Clone (dimension travel and death for example)

Actual Behavior

Leaks Client Player, Level, everything related to player.

Mod Pack URL (Optional)

No response

Mod Pack Version (Optional)

No response

Extra Notes (Optional)

No response

latest.log

check image

@mezz
Copy link
Owner

mezz commented Oct 4, 2024

Thanks for the report!
I have fixed the issue by avoiding storing the client player at all, and it will be released shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants