Fix generate (rtk_lef, lib) scripts with more recent open_pdks/volare builds #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects the lef name of the nominal tech lef introduced by the following open_pdks commit: RTimothyEdwards/open_pdks@e75eaa4
It seems newer open_pdks and volare builds have already implemented this particular hotfix. Applying this hotfix again yields invalid results, so let's remove it. Tested with: - open_pdks 1.0.367 - volare sky130 build: e6f9c8876da77220403014b116761b0b2d79aab4
Automated hotfix for 183 in preparation for processing other timing corners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1.
This updates some generate scripts to work with newer builds from open_pdks/volare. Didn't encounter an assertion error about sparecell, so I opted to remove it. Please let me know if this is still needed as I plan to support additional corners (https://github.com/hansemro/skywater-130nm/tree/ff_ss_corners_rebuild).
Tested with: