Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RangeError: Maximum call stack size exceeded #38

Closed
jliebrand opened this issue Oct 2, 2018 · 5 comments
Closed

RangeError: Maximum call stack size exceeded #38

jliebrand opened this issue Oct 2, 2018 · 5 comments
Labels
bug Something isn't working
Milestone
0.9

Comments

@jliebrand
Copy link
Contributor

For certain input values, there appears to be an infinite loop causing a max stack size to be reached.

I'll add a test case and a PR to show the issue (raising this issue first so that i can refer to it in code)
@jliebrand
Copy link
Contributor Author

See PR
#39

@jliebrand jliebrand mentioned this issue Oct 2, 2018
Closed
@mfogel mfogel added the bug Something isn't working label Oct 2, 2018
@jliebrand
Copy link
Contributor Author

@mfogel - I assume you dont want the PR to land without a fix, or else your build is broken? Any update on a potential fix?

@mfogel
Copy link
Owner

mfogel commented Oct 6, 2018

@jliebrand - yeah I don't want to merge in just the failing test case individually, at least not to master. I haven't had time to look at this bug yet, will hopefully get time ASAP but I can't promise. :/

@jliebrand
Copy link
Contributor Author

Ok great, I'll keep my eyes on this bug for now then :-)

@jliebrand
Copy link
Contributor Author

Hi @mfogel - I know you're busy, but any update on this and the other bugs?

@mfogel mfogel added this to the 0.9 milestone Oct 17, 2018
@mfogel mfogel closed this as completed in db3acf9 Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.9
Development

No branches or pull requests
2 participants
@mfogel @jliebrand