-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add event, location, and date frontmatter #317
Conversation
c4abc46
to
002cd13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
@mfontanini, the concern about documentation can be solved a few different ways---the best way is to version the docs so a user could see the docs for An easy fix in the near term though is to simply update I can remove the docs if you wish, but I do have several concerns about doing so:
Just let me know how you'd like to move forward! |
Yeah, I'm aware of this solution but I have limited time to spend on this project and this would be very low on my priority list. I'm sure however this would work it would be annoying though as I'll have to backport doc changes to all versions if it's a docs "fix" (e.g. a missing feature or something that's wrong) rather than a new feature being included.
Then if I find an issue or something missing in the current docs (e.g. your mermaid theme change), I'll need to manually remove all docs that only apply to nightly and not the latest release, generate the docs by hand, and push them which is a non negligible amount of work and very easy to mess up (e.g. end up including changes for nightly on the latest release's docs).
I don't really mind this tho :). I can actually sit down and add/change/clean up everything all at once.
Fair but this is on me, I should have made a note to myself.
Fair, but I think in its current form the solution is pretty bad as well. I obviously don't have numbers on this but I imagine almost nobody (maybe you're the 0.1%) will clone the repo and manually generate the docs just to see what's new on nightly. |
Alrighty 👍, I removed the doc changes |
Thanks! |
Thank you sir! |
Hello!
Closes #312
This PR adds fields for the presentation
event
,location
, anddate
---these are optional fields but are common frontmatter elements, particularly if the presentation is for a larger conference / event.Example:
Thanks!
P.S., I'm really new to Rust so sorry if I didn't do thing in the idiomatic Rust way!