-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More succint syntax for slide_end
and pause
#65
Comments
Can you expand on what you mean by alternative syntax? Do you want an abbreviation? |
An abbreviation, or just something that is a little less busy. I don't really have a good suggestion though, I don't know any syntax that would make sense and be compatible with Markdown, I just wanted to have your opinion on that. If you like the verbosity of the HTML comments because it makes them easier to spot, there's nothing to discuss! |
One big difference between slides and presenterm in this area is that slides doesn't support setex headers (the ones that presenterm uses as slide titles). Because slide titles are so common in presenterm, using thematic breaks becomes genuinely annoying as the difference between a slide ending and a slide title is a newline. I actually initially had thematic breaks as slide terminators but removed it exactly because of this: even in my dummy test presentations I couldn't easily spot where slides ended. I'd be okay with adding shorthands but I don't know if that simplifies things much as you still need to define the comment tags. I don't like the verbosity of HTML but given pauses and slide separators are not part of the markdown spec, we need something else and this fits. |
How about having implicit slide endings before slide titles? Right now Slide one
---
Here is my presentation...
Slide two
---
... and now it's done! results in a single slide with 2 titles. If you think that this isn't a valid use case, it could be made equivalent to Slide one
---
Here is my presentation...
<!-- end_slide -->
Slide two
---
... and now it's done! I'm thinking out loud here, I don't have a solid proposal, so feel free to close the issue :) Also regarding the shorthands, I agree that they are not worth much if they still require the comment syntax. |
Ohh interesting idea! I'm aware that you can currently have 2+ slide titles and it looks a bit weird so I don't see an issue adding this shorthand. |
Alright this is merged. I made it an optional behavior just in case so if you do want it you need to enable it by editting options:
implicit_slide_ends: true Let me know if there's any issues! |
I was going to implement it myself an hour ago and just saw that it... was already done? |
Actually, it seems that an empty slide gets added if a front matter is present, regardless of whether there is a title or not. ---
theme:
name: terminal-dark
---
Intro
---
Hello
Conclusion
---
Good bye |
Dang, it should be fixed now. The code that deals with state between markdown elements is pretty fragile. |
Would you consider supporting an alternative syntax for the commands that currently use HTML comments?
I understand that they are "more correct", but I also miss the writability (mitigated by the use of snippets) and readability of https://github.com/maaslalani/slides/ documents a little bit.
The text was updated successfully, but these errors were encountered: