Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vim.ui.select to choose options #500

Closed
IlyasYOY opened this issue Jun 4, 2023 · 2 comments
Closed

Use vim.ui.select to choose options #500

IlyasYOY opened this issue Jun 4, 2023 · 2 comments

Comments

@IlyasYOY
Copy link

IlyasYOY commented Jun 4, 2023

Problem Statement

Thank you for your work.

I've been using the extension for quite some time and I faced a problem with selection dialog.

There are usages of vim.ui.select and vim.fn.input, vim.fn.inputlist.

I found here that

nvim-jdtls uses vim.ui.select, that means plugins providing a vim.ui.select implementation are used.

So, is this possible to use select everywhere? It'd make extension more compatible with the others vim plugins.

I found 2 places where input is used:

Ideas or possible solutions

Replace input usages with select where possible. Maybe you already know why it's not.

I'd be glad to propose a PR, if you think it might be useful and possible.

@IlyasYOY IlyasYOY closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2023
@mikehaertl
Copy link
Contributor

Hmm, why was this closed? I'd also find this useful.

@IlyasYOY
Copy link
Author

Hello @mikehaertl

I thought that the issue is related to #358. I closed this as a duplicate.

You can reopen this one, if you think that it's worthy being open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants