Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to add Forbidden API Checker #195

Closed
mfvanek opened this issue Feb 2, 2023 · 6 comments · Fixed by #418
Closed

Consider to add Forbidden API Checker #195

mfvanek opened this issue Feb 2, 2023 · 6 comments · Fixed by #418
Assignees
@BLoHny
Labels
enhancement New feature or request
Milestone
0.13.0

Comments

@mfvanek
Copy link
Owner

mfvanek commented Feb 2, 2023

Add Forbidden API Checker instead of IllegalMethodCall from checkstyle
https://github.com/policeman-tools/forbidden-apis
https://plugins.gradle.org/plugin/de.thetaphi.forbiddenapis
@mfvanek mfvanek added enhancement New feature or request help wanted Extra attention is needed labels Feb 2, 2023
@mfvanek
Copy link
Owner Author

mfvanek commented Feb 2, 2023

Example of usage https://github.com/pgjdbc/pgjdbc/blob/master/config/forbidden-apis/forbidden-apis.txt

@BLoHny
Copy link
Collaborator

BLoHny commented Jun 9, 2024

Can i try it?

@mfvanek mfvanek removed the help wanted Extra attention is needed label Jun 9, 2024
@mfvanek
Copy link
Owner Author

mfvanek commented Jun 9, 2024

Can i try it?

@BLoHny yes, sure

@BLoHny
Copy link
Collaborator

BLoHny commented Jun 10, 2024

Should I configure Forbidden Check to root or just the pg-index-health module?

@mfvanek
Copy link
Owner Author

mfvanek commented Jun 10, 2024

Should I configure Forbidden Check to root or just the pg-index-health module?

It should be applied to root and should work for all subprojects

@BLoHny BLoHny mentioned this issue Jun 10, 2024
Merged
@BLoHny BLoHny linked a pull request Jun 10, 2024 that will close this issue
Add forbidden api checker #418
Merged
@mfvanek
Copy link
Owner Author

mfvanek commented Jun 12, 2024

@BLoHny
Could you add these checks to the https://github.com/mfvanek/pg-index-health-demo as well?

@mfvanek mfvanek mentioned this issue Jun 22, 2024
Merged
@mfvanek mfvanek added this to the 0.13.0 milestone Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BLoHny BLoHny

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Add forbidden api checker mfvanek/pg-index-health
2 participants
@mfvanek @BLoHny