Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove applications key from MixProject.application/0 #63

Open
Sgoettschkes opened this issue Apr 16, 2024 · 0 comments
Open

Remove applications key from MixProject.application/0 #63

Sgoettschkes opened this issue Apr 16, 2024 · 0 comments

Comments

@Sgoettschkes
Copy link

The applications key in OpenAI.MixProject.application/0 is most likely a relict from older mix versions. I don't think it does serve a purpose anymore and we get compiler warnings in our project when compiling this library.

openai.ex/mix.exs

Lines 22 to 23 in dd48493

applications: [:httpoison, :jason, :logger],
extra_applications: [:logger]

If somebody can confirm that there is no specific reason to keep the applications key around, I'm happy to do a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant