Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.MissingMethod exception with AngleSharp 0.9.4 #53

Closed
rmichela opened this issue Feb 2, 2016 · 3 comments
Closed

System.MissingMethod exception with AngleSharp 0.9.4 #53

rmichela opened this issue Feb 2, 2016 · 3 comments

Comments

@rmichela
Copy link

rmichela commented Feb 2, 2016

After updating to AngleSharp 0.9.4, HtmlSanitizer.Sanitize() started throwing a MissingMethodException.

Method not found: 'System.String AngleSharp.IStyleFormattable.ToCss()'
at Ganss.XSS.HtmlSanitizer.SanitizeStyle(IHtmlElement element, String baseUrl)
at Ganss.XSS.HtmlSanitizer.Sanitize(String html, String baseUrl, IMarkupFormatter outputFormatter)

Reverting to AngleSharp 0.9.3 fixed the problem.

@304NotModified
Copy link
Contributor

I think angelsharp isn't following semver then.

@mganss mganss closed this as completed in db51e9b Feb 3, 2016
@mganss
Copy link
Owner

mganss commented Feb 3, 2016

The method was moved from the interface to an extension method in AngleSharp/AngleSharp@59d98f0, causing binary incompatibility. Recompiling fixes it. Will release a new version shortly.

@304NotModified
Copy link
Contributor

Ow the apply to semver I see:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

http://semver.org/#spec-item-4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants