Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty print removes blank text node between inline elements #58

Open
muzimuzhi opened this issue Dec 1, 2022 · 0 comments
Open

Pretty print removes blank text node between inline elements #58

muzimuzhi opened this issue Dec 1, 2022 · 0 comments

Comments

@muzimuzhi
Copy link

muzimuzhi commented Dec 1, 2022 •
edited
Loading 

$ echo '<code>x</code> <code>y</code>' | htmlq -p body

<body><code>x</code><code>y</code>
</body>%

Here "blank" text node means a text node contains only whitespaces.

Since <code>x</code> <code>y</code> and <code>x</code><code>y</code> give different rendering output, htmlq changes the semantic of this HTML snippet.

It seems the condition on line 70 (see code snippet below) is too loose. Not sure if self.previous_was_block && text.trim().is_empty() is enough.

htmlq/src/pretty_print.rs

Lines 69 to 81 in 739cd36

fn write_text(&mut self, text: &str) -> io::Result<()> {
if text.trim().is_empty() {
Ok(())
} else {
if self.previous_was_block {
self.inner.writer.write_all(b"\n")?;
self.inner.writer.write_all(&vec![b' '; self.indent])?;
}
self.previous_was_block = false;
self.inner.write_text(text)
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@muzimuzhi