Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Babel 7's @babel/plugin-proposal-decorators in modern mode #72

Open
matthewadams opened this issue Nov 14, 2018 · 0 comments
Open

Comments

@matthewadams
Copy link
Collaborator

aspect.js@0.7.5 fails when using @babel/plugin-proposal-decorators@>=7.1.6 in a pure JavaScript project. The workaround is to set the plugin's legacy property to true.

Since the modern (legacy: false) mode of the plugin is now the default and closer to the expected final version of the ECMAScript decorators proposal, aspect.js should be updated accordingly to work with the plugin's modern mode. For backward compatibility, there should probably be an aspect.js setting to opt-in to using the modern decorator mode. The next major version of aspect.js could then be changed to use the modern mode by default.

The project at https://github.com/matthewadams/aspect.js-babel7-poc can be used as a pure JavaScript test client for such an environment for integration testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant