fix(allow-template-call-expression): allow $any in expressions (#735)

mgechev · Jan 30, 2019 · a75c204 · a75c204
1 parent 0ed079f
commit a75c204
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/noTemplateCallExpressionRule.ts b/src/noTemplateCallExpressionRule.ts
@@ -33,14 +33,18 @@ class TemplateVisitor extends BasicTemplateAstVisitor {
 }
 
 class ExpressionVisitor extends RecursiveAngularExpressionVisitor {
+  private allowedMethodNames = ['$any'];
+
   visitFunctionCall(node: e.FunctionCall, context: any) {
     this.addFailureFromStartToEnd(node.span.start, node.span.end, Rule.FAILURE_STRING);
 
     super.visitFunctionCall(node, context);
   }
 
   visitMethodCall(node: e.MethodCall, context: any) {
-    this.addFailureFromStartToEnd(node.span.start, node.span.end, Rule.FAILURE_STRING);
+    if (this.allowedMethodNames.indexOf(node.name) === -1) {
+      this.addFailureFromStartToEnd(node.span.start, node.span.end, Rule.FAILURE_STRING);
+    }
 
     super.visitMethodCall(node, context);
   }

diff --git a/test/noTemplateCallExpressionRule.spec.ts b/test/noTemplateCallExpressionRule.spec.ts
@@ -21,6 +21,16 @@ describe('no-template-call-expression', () => {
       `;
       assertSuccess('no-template-call-expression', source);
     });
+
+    it('should allow $any to wrap unknown variables', () => {
+      let source = `
+        @Component({
+          template: '{{$any(info)}}'
+        })
+        class Bar {}
+      `;
+      assertSuccess('no-template-call-expression', source);
+    });
   });
 
   describe('failure', () => {