Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: component-class-suffix give a list of possible suffixes #194

Closed
pierre-hilt opened this issue Dec 14, 2016 · 3 comments
Closed

Comments

@pierre-hilt
Copy link

Hello,

In our project we use several Suffix for our component depending if they are Component or Simple View (so we use Component and View suffix).

It could be great to propose a list of possible suffix for component-class-suffix.

I have already done some code and ready to do a PR if you think that can be a good idea to add this.

"component-class-suffix": [true, "Component", "View"]

Pierre

@mgechev
Copy link
Owner

mgechev commented Dec 14, 2016

Hey @pierre-hilt, we already had a discussion about this. I'm not confident how good idea is it because we're going in a different direction from the official style guide. In the same time we're only expanding the set of features without preventing developers align their codebase to best practices.

I'd love to get a PR with this functionality.

@pierre-hilt
Copy link
Author

#195

@pierre-hilt
Copy link
Author

I see that is not compliant with Angular best practices. But I will need to disable completely the rule in my project without this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants