Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no-output-on-prefix): fix regular expression #674

Merged
merged 3 commits into from
Jun 24, 2018
Merged

fix(no-output-on-prefix): fix regular expression #674

merged 3 commits into from
Jun 24, 2018

Conversation

loktionov129
Copy link
Contributor

this commit fixes incorrect behavior when memberName contains 'on' suffix in the word, for example selectionChanged.

/on((?![a-z])|(?=$))/.test('selectionChanged');
// true

/^on((?![a-z])|(?=$))/.test('selectionChanged');
// false

this commit fixes incorrect behavior when memberName contains 'on' suffix in the word, for example selectionChanged.

```
/on((?![a-z])|(?=$))/.test('selectionChanged');
// true

/^on((?![a-z])|(?=$))/.test('selectionChanged');
// false
```
@rafaelss95
Copy link
Collaborator

Good catch! Could you add a test containing a case like this you mentioned?

@@ -69,4 +69,16 @@ describe('no-output-on-prefix', () => {
assertSuccess('no-output-on-prefix', source);
});
});

describe('valid output property name', () => {
it("should succeed, when a output property containing 'on' suffix", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a -> an. Also, you can put this test in the above describe.

@rafaelss95
Copy link
Collaborator

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants