Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Injectable() instead of Injectable #70

Closed
JohannesRudolph opened this issue Jul 21, 2016 · 2 comments
Closed

Use Injectable() instead of Injectable #70

JohannesRudolph opened this issue Jul 21, 2016 · 2 comments
Assignees
@mgechev
Labels
enhancement P3
Milestone
Beta 0 - Nepeta

Comments

@JohannesRudolph
Copy link

According to https://angular.io/docs/ts/latest/guide/dependency-injection.html

ALWAYS INCLUDE THE PARENTHESES
Always write @Injectable(), not just @Injectable. Our application will fail mysteriously if we forget the parentheses.

It would be great if codelyzer could enforce this as a tslint rule (unless it's already enforced somehow?)
@mgechev mgechev self-assigned this Jul 21, 2016
@mgechev
Copy link
Owner

mgechev commented Jul 21, 2016 •
edited
Loading

Nice suggestion! I'll work on this style during the weekend.

@mgechev mgechev added this to the Beta 1 - Nepeta milestone Sep 21, 2016
@mgechev mgechev added the P3 label Sep 21, 2016
@JohannesRudolph
Copy link
Author

Cool, thanks a lot for implementing this!

@lazarljubenovic lazarljubenovic mentioned this issue Mar 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgechev mgechev

Labels
enhancement P3
Projects
None yet
Milestone
Beta 0 - Nepeta
Development

No branches or pull requests
2 participants
@JohannesRudolph @mgechev