Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe/Directive/Component naming conventions should be more consistent #79

Closed
DethAriel opened this issue Aug 15, 2016 · 1 comment
Closed

Comments

@DethAriel
Copy link

Here are the current naming-related options:

{
  "pipe-naming": [true, "camelCase", "sg"],
  "directive-selector-name": [true, "camelCase"],
  "component-selector-name": [true, "kebab-case"],
  "directive-selector-prefix": [true, "sg"],
  "component-selector-prefix": [true, "sg"],
  "component-class-suffix": true,
  "directive-class-suffix": true
}

Not only are they inconsistent (I mean "pipe-*" versus "component-*"), there's just too many of them. Maybe the below format would be more appropriate/easier:

{
  "[pipe|directive|component]-naming": [
    true,
    {
      "selector-prefix": "sg",
      "selector": "[camelCase|kebab-case]",
      // or, to make this somewhat future-proof
      // "selector": ["camelCase", "tolerate-kebab-case", "tolerate-PascalCase"]
      "suffix": true|false,
    }
  ]
}
@mgechev mgechev added this to the Beta 2 - Dark Realm milestone Sep 21, 2016
@mgechev mgechev modified the milestones: Beta 2 - Trichocolea mollissima, Beta 1 - Dark Realm Oct 2, 2016
@mgechev
Copy link
Owner

mgechev commented Nov 14, 2016

We have improvement in this direction. We will change the configuration a bit in near future, for sure, but for now I think the current configuration schema makes a lot of sense.

Closed by 3373dff.

@mgechev mgechev closed this as completed Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants