prune ** excludes absolutely everything, even if followed by graft and include directives
#144
Comments
|
This is a bug, or, more precisely, a missing feature: check-manifest currently processes exclude directives (such as I would like to fix it some day. |
mgedmin
changed the title
** like setuptools does?prune ** excludes absolutely everything, even if followed by graft and include directives
Thanks for the very responsive reply @mgedmin — truly appreciate it! This information is helpful, so thanks for clarifying the situation.
I assume that this is nontrivial and not something that is an appropriate contribution for a first time contributor to the project. But, if I was selfishly interested in trying to help address this, do you have any advice on where to start working? I should of course also just start looking myself. |
I have this IgnoreList class that currently collects all the exclusion rules. It needs to be extended to handle include rules in proper order and renamed to something like RuleList. Then read_manifest()'s inner helpers need to be changed (and renamed) so they handle all the include directives (there's an XXX comment) and return a RuleList instead of an IgnoreList. Then I have to figure out how ignore rules specified in check-manifest's configuration interact with MANIFEST's include/exclude rules, order-wise, and maybe update the And, of course, unit tests for all of the above. Oh dear, I haven't migrated to pytest yet, that's a shame. Well, the end-of-life of Python 3.5 makes things easier there -- the Windows console issue that was a blocker should no longer be a blocker. Eh, maybe unittest isn't that bad. The highest risk is that I might be too burned out to review a PR in a timely fashion. (I'm currently failing to review three other PR's that are sitting there in open browser tabs since July.) |
After looking around in the Issues related to
pruneI think the answer is "no", but I thought I'd ask here explicitly though I think this is just (maybe?) related to Issue #115.A project I work on has
prune **in ourMANIFEST.in, which I'll copy here as well:I've recently noticed that while
check-manifestis passing when run here, it isn't doing anything as it finds0files(Aside: This might be a nice place to fail out on the user)
However, as (according to the Including files in source distributions with
MANIFEST.inPyPA guide)buildwill happily make an sdist and wheel that has the correct file contents.Full dump from the above:
Given Issue #115, does this mean
check-manifestis incompatible with this syntax and to usecheck-manifestusers should manually add / exclude all top level files?cc @alexander-held
The text was updated successfully, but these errors were encountered: