Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function show_growth return deltas #34

Closed
xybaby opened this issue Dec 27, 2017 · 2 comments
Closed

function show_growth return deltas #34

xybaby opened this issue Dec 27, 2017 · 2 comments

Comments

@xybaby
Copy link
Contributor

xybaby commented Dec 27, 2017

I am using function show_growth to find memory leak in my project. Howerver, at the moment, the result outputs to stdout or file.I just wonder if we can return the result, with which we can automaticly detech memory leak when regression testing.
To achieve the target, I have two suggestion. First, simple but ungraceful, just return deltas in function show_growth. Second, adding a function get_growth, which return the increasing deltas, and the function show_growth just output the increasing deltas

@mgedmin
Copy link
Owner

mgedmin commented Dec 27, 2017

Splitting this into two functions makes sense to me.

(This is what happened to show_most_common_types(): most_common_types() was extracted from it.)

@xybaby
Copy link
Contributor Author

xybaby commented Dec 28, 2017

ok, i have pulled a merge request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants