Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nightly compiler warnings #103

Closed
ldm0 opened this issue Feb 13, 2021 · 2 comments
Closed

New nightly compiler warnings #103

ldm0 opened this issue Feb 13, 2021 · 2 comments

Comments

@ldm0
Copy link

ldm0 commented Feb 13, 2021

e.g.

pub fn foo() {
    version_sync::assert_markdown_deps_updated!("README.md");
    version_sync::assert_html_root_url_updated!("src/lib.rs");
}

Compiler warnings:

warning: panic message is not a string literal
 --> src/main.rs:3:5
  |
3 |     version_sync::assert_markdown_deps_updated!("README.md");
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(non_fmt_panic)]` on by default
  = note: this is no longer accepted in Rust 2021
  = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

warning: panic message is not a string literal
 --> src/main.rs:4:5
  |
4 |     version_sync::assert_html_root_url_updated!("src/lib.rs");
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this is no longer accepted in Rust 2021
  = note: this warning originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

warning: 2 warnings emitted

Change panic!(err) to panic!("{}", err) will fix this issue. Check rust-lang/rust#81645.

@mgeisler
Copy link
Owner

Hi @ldm0, thank you very much for the report! This was fixed already by @lopopolo in #95. I'm making a release with the fix as we speak.

@mgeisler
Copy link
Owner

The new version is released: https://crates.io/crates/version-sync/0.9.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants