Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment columns with 0s fail #66

Open
pjrule opened this issue Aug 24, 2020 · 0 comments
Open

Assignment columns with 0s fail #66

pjrule opened this issue Aug 24, 2020 · 0 comments

Comments

@pjrule
Copy link
Collaborator

pjrule commented Aug 24, 2020

This issue was reported by @gabeschoenbach and can be resolved by incrementing each value in the assignment column by 1. Assignment values are used as array indices in some places—we normally assume that assignments start from 1 and are in the range [1, n_districts]. However, this is not universally true—some assignments may start with 0 and may be non-consecutive. Let's talk about the cleanest way to deal with this. One easy option is to simply enforce our assumption in a preprocessing step and shift the burden to the user, but I'm not sure what the UX would be here.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant